[libcxx-commits] [PATCH] D60491: Fix fpos requirements & cleanup
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed May 22 07:41:25 PDT 2019
zoecarver marked an inline comment as done.
zoecarver added inline comments.
================
Comment at: include/string:529
streamoff __off_;
public:
+ _LIBCPP_INLINE_VISIBILITY fpos() : __st_(), __off_(0 ) {}
----------------
mclow.lists wrote:
> zoecarver wrote:
> > I re-ordered and updated these operators and member functions. I don't think it changes any of the functionality so I am fine without the updates (say the word, and I will remove the changes).
> I think that's a good idea. This paper is supposed to be just wording cleanup; no changes to functionality, so lets make this patch just a test cleanup.
>
> The re-ordering, etc of the member functions and operators can be done afterwards as a NFC patch.
Sounds good. I will remove this part of the patch and re-upload the diff.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60491/new/
https://reviews.llvm.org/D60491
More information about the libcxx-commits
mailing list