[libcxx-commits] [PATCH] D62233: General shared_ptr cleanup

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 22 07:36:39 PDT 2019


zoecarver added a comment.

Thanks for the explanation @mclow.lists I didn't fully understand the importance of using `compressed_pair` (or that removing it would cause an ABI break). I don't have a "good" reason for removing `compressed_pair` other than, I got tired of typing out `.second().second()` and remembering which child class uses which order of elements (which is not a good reason). I will remove that change.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62233/new/

https://reviews.llvm.org/D62233





More information about the libcxx-commits mailing list