[libcxx-commits] [PATCH] D62103: Update shared_ptr tests to match the standard

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 18 13:31:27 PDT 2019


zoecarver created this revision.
zoecarver added reviewers: mclow.lists, EricWF, ldionne.
Herald added subscribers: libcxx-commits, dexonsmith.

This patch updates the `shared_ptr` tests so that they more closely and more completely match the standard. I think it is essential that these tests match //exactly// what the standard says and test it completely because I am going to use them when making significant changes to `shared_ptr`.

For reference here is the relevant section of the current standard. <http://eel.is/c++draft/util.smartptr.shared>

Currently, I have only updated the constructor tests. However, I plan on updating all of the `shared_ptr` tests (either in this patch or another).


Repository:
  rCXX libc++

https://reviews.llvm.org/D62103

Files:
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/types.pass.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/default.pass.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer.pass.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter.fail.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter.pass.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter_allocator.pass.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/shared_ptr_Y_rv.pass.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/shared_ptr_copy_move.fail.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/shared_ptr_pointer.pass.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/unique_ptr.pass.cpp
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.obs/op_bool.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62103.200157.patch
Type: text/x-patch
Size: 20191 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190518/3cc7bb52/attachment-0001.bin>


More information about the libcxx-commits mailing list