[libcxx-commits] [PATCH] D62060: Make libc++'s libc++abi discovery work in the monorepo layout

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added inline comments.


================
Comment at: libcxx/CMakeLists.txt:150
+  # is always there and LLVM_ENABLE_PROJECTS controls if it's built.
+  # In the old layout, libcxxabi is built if it merely exists.
+  if (NOT LIBCXX_STANDALONE_BUILD AND
----------------
This isn't quite true either. You could define `LLVM_TOOL_LIBCXXABI_BUILD` to `OFF` to prevent the build. It just defaulted to building instead of defaulting to not building.


================
Comment at: libcxx/CMakeLists.txt:152
+  if (NOT LIBCXX_STANDALONE_BUILD AND
+      (LLVM_ENABLE_PROJECTS_USED OR NOT LLVM_ENABLE_PROJECTS STREQUAL ""))
+    if ("libcxxabi" IN_LIST LLVM_ENABLE_PROJECTS)
----------------
Why do we need to check both of these?


================
Comment at: libcxx/CMakeLists.txt:153
+      (LLVM_ENABLE_PROJECTS_USED OR NOT LLVM_ENABLE_PROJECTS STREQUAL ""))
+    if ("libcxxabi" IN_LIST LLVM_ENABLE_PROJECTS)
+      set(LIBCXX_HAVE_LIBCXXABI_CHECKOUT_INTERNAL TRUE)
----------------
What about `LLVM_ENABLE_RUNTIMES`? I think this might break that ... CC @phosek 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62060/new/

https://reviews.llvm.org/D62060