[libcxx-commits] [PATCH] D61869: Fix PR41843 - std::is_base_of should give correct result for incomplete unions

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 15 19:02:06 PDT 2019


mclow.lists added a comment.

In D61869#1501975 <https://reviews.llvm.org/D61869#1501975>, @ldionne wrote:

> In D61869#1500407 <https://reviews.llvm.org/D61869#1500407>, @mclow.lists wrote:
>
> > an alternate approach would be to add an entirely new test, and XFAIL it for the compilers in question.
>
>
> I have a slight preference for an `XFAIL`ed test, but you can do whatever. Thanks for adding a test.


I will do that; but I won't put it up here for review; I'll just commit it.
Leaving this open so that I can record when the test is landed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61869/new/

https://reviews.llvm.org/D61869





More information about the libcxx-commits mailing list