[libcxx-commits] [PATCH] D61954: Ensure that hash<basic_string> uses char_traits (41876)

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 15 14:20:39 PDT 2019


zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: test/std/strings/basic.string.hash/char_type_hash.fail.cpp:24
+    typedef int       int_type;
+    typedef streamoff off_type;
+    typedef streampos pos_type;
----------------
mclow.lists wrote:
> zoecarver wrote:
> > mclow.lists wrote:
> > > these may need `std::` qualifications
> > See line 17.
> We don't usually do `using namespace std;` in our tests.
Good to know. I will remove it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61954/new/

https://reviews.llvm.org/D61954





More information about the libcxx-commits mailing list