[libcxx-commits] [PATCH] D61954: Ensure that hash<basic_string> uses char_traits (41876)

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added inline comments.


================
Comment at: test/std/strings/basic.string.hash/char_type_hash.fail.cpp:28
+
+    static inline void _LIBCPP_CONSTEXPR_AFTER_CXX14
+        assign(char_type& __c1, const char_type& __c2) _NOEXCEPT {__c1 = __c2;}
----------------
You should get rid of the `_LIBCPP_CONSTEXPR_AFTER_CXX14` and `_LIBCPP_CONSTEXPR` and `_LIBCPP_INLINE_VISIBILITY`  and `_NOEXCEPT` bits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61954/new/

https://reviews.llvm.org/D61954