[libcxx-commits] [PATCH] D61792: [PPC] Fix 32-bit build of libunwind

[Brandon Bergren via Phabricator via libcxx-commits]

Bdragon28 marked an inline comment as done.
Bdragon28 added inline comments.


================
Comment at: libunwind/src/assembly.h:32
-#elif defined(__POWERPC__) || defined(__powerpc__) || defined(__ppc__)
-#define SEPARATOR @
 #elif defined(__arm64__)
----------------
luporl wrote:
> compnerd wrote:
> > Why the removal of this?  This is the correct separator IIRC.
> Because clang's integrated assembler does not recognize '@' as a separator, but both clang and GNU as recognize ';' as a separator.
> Maybe this part was also added when cctools were being used?
Additionally, @ actually means something in PPC64 asm. It's used for indirect references.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61792/new/

https://reviews.llvm.org/D61792