[libcxx-commits] [PATCH] D58587: Implement P0433: deduction guides for <map>

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone marked an inline comment as done.
Quuxplusone added inline comments.


================
Comment at: include/map:1474
+         class _Allocator = allocator<pair<const _Key, _Tp>>,
+         class = typename enable_if<!__is_allocator<_Compare>::value, void>::type,
+         class = typename enable_if<__is_allocator<_Allocator>::value, void>::type>
----------------
ldionne wrote:
> Quuxplusone wrote:
> > ldionne wrote:
> > > So those `enable_if`s are required to avoid colliding with the `map(initializer_list<pair<_Key, _Tp>>, _Allocator)` deduction guide, correct?
> > Yes, that's right. They correspond directly with the SFINAE requirements in
> > http://eel.is/c++draft/container.adaptors.general#4
> Those requirements are for container adapters -- do we have similar requirements for `map` and `set`?
Oops, you're absolutely right. Yes we do; the requirements for `map` and `set` are in
http://eel.is/c++draft/associative.reqmts#15 (which is what I should have said above instead of http://eel.is/c++draft/container.adaptors.general#4).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58587/new/

https://reviews.llvm.org/D58587