[libcxx-commits] [PATCH] D61771: Comparing Unordered Containers (P0809)

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

I know that Louis and Eric disagree, but I'd rather have four tests, one for each of the unordered containers, rather than just one.
(unless someone wants to step up and re-do all the container tests, and I'm not hearing any enthusiasm for that).



================
Comment at: test/std/containers/unord/comp_different_hash.pass.cpp:49
+template<class T>
+size_t hash_neg      (T val)     { return std::numeric_limits<size_t>::max() - val; }
+template<class T>
----------------
I don't think that this does what what you want anymore.


================
Comment at: test/std/containers/unord/comp_different_hash.pass.cpp:71
+    {
+        m.insert(std::make_pair(*p1, *p2));
+    }
----------------
The first time through the loop you are dereferencing `p2`, which is equal to `end`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61771/new/

https://reviews.llvm.org/D61771