[libcxx-commits] [PATCH] D58587: Implement P0433: deduction guides for <map>

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 3 14:17:29 PDT 2019


Quuxplusone updated this revision to Diff 198084.
Quuxplusone added a comment.

Review comments on the unit tests.
Also, it looks like my initial upload didn't actually include the LWG3025 fix? The fix involves the `remove_const` that's now in most of the deduction guides (and a new test file to test the change).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58587/new/

https://reviews.llvm.org/D58587

Files:
  include/iterator
  include/map
  test/std/containers/associative/map/map.cons/deduct.fail.cpp
  test/std/containers/associative/map/map.cons/deduct.pass.cpp
  test/std/containers/associative/map/map.cons/deduct_const.pass.cpp
  test/std/containers/associative/multimap/multimap.cons/deduct.fail.cpp
  test/std/containers/associative/multimap/multimap.cons/deduct.pass.cpp
  test/std/containers/associative/multimap/multimap.cons/deduct_const.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58587.198084.patch
Type: text/x-patch
Size: 38084 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190503/c2e5ca42/attachment-0001.bin>


More information about the libcxx-commits mailing list