[libcxx-commits] [PATCH] D48292: use modern type trait implementations when available

Fri May 3 09:53:55 PDT 2019

thakis added a comment.

This test is broken with Xcode 9:

  -- Testing: 53613 tests, 8 threads --
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90
  FAIL: libc++ :: std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp (50845 of 53613)
  ******************** TEST 'libc++ :: std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp' FAILED ********************
  Command: ['/Applications/Xcode9.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++', '-o', '/b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/Output/is_trivially_destructible.pass.cpp.o', '-x', 'c++', '/b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp', '-c', '-D_LIBCPP_DISABLE_AVAILABILITY', '-v', '-arch', 'x86_64', '-mmacosx-version-min=10.12', '-ftemplate-depth=270', '-Werror=thread-safety', '-std=c++1z', '-include', '/b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/support/nasty_macros.hpp', '-nostdinc++', '-I/b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/include', '-I/b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/include/c++build', '-isysroot', '/Applications/Xcode9.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk', '-I/b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/support', '-DLIBCXX_FILESYSTEM_STATIC_TEST_ROOT="/b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/std/input.output/filesystems/Inputs/static_test_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT="/b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/test/filesystem/Output/dynamic_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_HELPER="/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/support/filesystem_dynamic_test_helper.py"', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wall', '-Wextra', '-Werror', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-c']
  Exit Code: 1
  Standard Error:
  --
  Apple LLVM version 9.0.0 (clang-900.0.37)
  Target: x86_64-apple-darwin16.7.0
  Thread model: posix
  InstalledDir: /Applications/Xcode9.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
   "/Applications/Xcode9.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang" -cc1 -triple x86_64-apple-macosx10.12.0 -Wdeprecated-objc-isa-usage -Werror=deprecated-objc-isa-usage -emit-obj -mrelax-all -disable-free -disable-llvm-verifier -discard-value-names -main-file-name is_trivially_destructible.pass.cpp -mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim -fno-strict-return -masm-verbose -munwind-tables -target-cpu penryn -target-linker-version 302.3 -v -dwarf-column-info -debugger-tuning=lldb -coverage-notes-file /b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/Output/is_trivially_destructible.pass.cpp.gcno -nostdinc++ -resource-dir /Applications/Xcode9.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0 -include /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/support/nasty_macros.hpp -isysroot /Applications/Xcode9.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -D _LIBCPP_DISABLE_AVAILABILITY -I /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/include -I /b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/include/c++build -I /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/support -D "LIBCXX_FILESYSTEM_STATIC_TEST_ROOT=\"/b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/std/input.output/filesystems/Inputs/static_test_env\"" -D "LIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT=\"/b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/test/filesystem/Output/dynamic_env\"" -D "LIBCXX_FILESYSTEM_DYNAMIC_TEST_HELPER=\"/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/support/filesystem_dynamic_test_helper.py\"" -D _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -stdlib=libc++ -Werror=thread-safety -Wall -Wextra -Werror -Wuser-defined-warnings -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -std=c++1z -fdeprecated-macro -fdebug-compilation-dir /b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop -ftemplate-depth 270 -ferror-limit 19 -fmessage-length 0 -stack-protector 1 -fblocks -fobjc-runtime=macosx-10.12.0 -fencode-extended-block-signature -fcxx-exceptions -fexceptions -fmax-type-align=16 -fdiagnostics-show-option -o /b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/Output/is_trivially_destructible.pass.cpp.o -x c++ /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp
  clang -cc1 version 9.0.0 (clang-900.0.37) default target x86_64-apple-darwin16.7.0
  ignoring nonexistent directory "/Applications/Xcode9.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/local/include"
  ignoring nonexistent directory "/Applications/Xcode9.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/Library/Frameworks"
  #include "..." search starts here:
  #include <...> search starts here:
   /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/include
   /b/rr/tmp7bTZVi/w/src/third_party/llvm-bootstrap/projects/libcxx/include/c++build
   /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/support
   /Applications/Xcode9.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0/include
   /Applications/Xcode9.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
   /Applications/Xcode9.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include
   /Applications/Xcode9.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks (framework directory)
  End of search list.
  /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp:24:5: error: static_assert failed ""
      static_assert( std::is_trivially_destructible<T>::value, "");
      ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /b/rr/tmp7bTZVi/w/src/third_party/llvm/projects/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp:120:5: note: in instantiation of function template specialization 'test_is_trivially_destructible<_Atomic(int)>' requested here
      test_is_trivially_destructible<_Atomic int>();
      ^

Does this just need an `// XFAIL: apple-clang-9` or is this unexpected?

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48292/new/

https://reviews.llvm.org/D48292