[libcxx-commits] [PATCH] D61170: Use std::move in numeric algorithms

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added inline comments.


================
Comment at: test/std/numerics/numeric.ops/accumulate/accumulate_op.pass.cpp:52
+{
+    std::size_t size = 100;
+    rvalue_addable arr[size];
----------------
Let's not require C99 VLAs to run our tests.



================
Comment at: test/std/numerics/numeric.ops/accumulate/accumulate_op.pass.cpp:60
+
+void
+test_string()
----------------
You can do this test at C++03.


================
Comment at: test/std/numerics/numeric.ops/adjacent.difference/adjacent_difference_op.pass.cpp:75
+    std::adjacent_difference(sa, sa + 3, output, std::plus<std::string>());
+    for (unsigned i = 0; i < 3; ++i) assert(output[i] == sr[i]);
+}
----------------
nit: line break.
Also, this test doesn't require C++11


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61170/new/

https://reviews.llvm.org/D61170