[libcxx-commits] [PATCH] D61139: (ABI break) Remove could-be-defaulted SMFs from `stack` and `queue` and `priority_queue`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D61139#1486268 <https://reviews.llvm.org/D61139#1486268>, @Quuxplusone wrote:

> [...]
>
> `SNIPPET 1` suffers from the problems I said: (1) it uses a config macro so now there's two codepaths to test,


But that's already a code path we need to test, since it's the ABI v2. So it's not adding a new configuration we need to test, it's just changing a code path we should already be testing.

> and (2) it changes `queue` from "conditionally trivially destructible" to "never trivially destructible."

Yes, you're right. I thought my snippet said:

  #if defined(_LIBCPP_ABI_CONTAINER_ADAPTERS_ALWAYS_NONTRIVIAL)
    ~queue() = default;
  #endif

but I was mistaken, and this wouldn't have the intended effect anyways.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61139/new/

https://reviews.llvm.org/D61139