[libcxx-commits] [PATCH] D61348: [libcxx] add debug-mode feature flag

[Brian Cain via Phabricator via libcxx-commits]

bcain added a comment.

In D61348#1486014 <https://reviews.llvm.org/D61348#1486014>, @mclow.lists wrote:

> In D61348#1485462 <https://reviews.llvm.org/D61348#1485462>, @EricWF wrote:
>
> > These tests turn on debug mode themselves - they don't need to be limited the configurations where the user turns it on.
>
>
> These tests need to be fixed so that they DTRT when the user specifies `-debug_level=X` (where X is 0/1) as a LIT param as well.


Ok but does that mean that the `REQUIRES` only belongs on a subset of the tests?  Ones with `MODULES_DEFINES: _LIBCPP_DEBUG=1` maybe?

I got here (to this change) indirectly.  One of our hexagon targets doesn't support waitpid() so we see compilation failures on the tests that include `debug_mode_helper.h`.  When I read this comment regarding system lib I think I misunderstood and assumed that these tests only are necessary for some library configurations.

I can follow-through on this change if you and Eric agree on what it should be.  But maybe I will work on a feature test for waitpid (`LIBCXX_HAVE_WAITPID`?) instead (or in addition) and somehow gate these tests that way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61348/new/

https://reviews.llvm.org/D61348