[libcxx-commits] [PATCH] D59921: [libunwind] Export the unw_* symbols as weak symbols

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libunwind/src/assembly.h:97
+#define WEAK_ALIAS(name, aliasname)                       \
+  WEAK_SYMBOL(aliasname) SEPARATOR                        \
+  SYMBOL_NAME(aliasname) = SYMBOL_NAME(name)
----------------
Thanks, this looks great overall now! Just one minor mistake.

The mingw version of the `WEAK_ALIAS` macro lacks a definition of `WEAK_SYMBOL()` - to match the C version we probably should just leave it out? With that changed, this compiles and links just fine.

Didn't test the non-mingw codepaths though.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59921/new/

https://reviews.llvm.org/D59921