[libcxx-commits] [PATCH] D60005: [libc++abi] Don't set POSITION_INDEPENDENT_CODE when building static library

Fri Mar 29 12:36:27 PDT 2019

sbc100 added a comment.

In D60005#1448211 <https://reviews.llvm.org/D60005#1448211>, @phosek wrote:

> @ldionne recently addressed this for libc++ in D59248 <https://reviews.llvm.org/D59248>. I already mentioned in the review that we should make the same change for libc++abi and libunwind. This would address your problem but also make libc++abi and libunwind build more aligned. I'm happy to prepare that change unless you want to do it?

Sure thing please go ahead.   Is there something you would different to this change?   If not, any reason to land this first/now?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60005/new/

https://reviews.llvm.org/D60005