[libcxx-commits] [PATCH] D59921: [libunwind] Export the unw_* symbols as weak symbols

[Roland McGrath via Phabricator via libcxx-commits]

mcgrathr added inline comments.


================
Comment at: libunwind/src/Unwind-EHABI.cpp:443
   // from scratch thus achieving the same effect.
-  unw_init_local(cursor, uc);
+  _unw_init_local(cursor, uc);
 
----------------
ldionne wrote:
> I don't think a single leading underscore followed by a lowercase letter is a reserved name (or maybe it is, but only in the global namespace?). I suggest we use two leading underscores for consistency.
Single leading _ is reserved for external linkage.  `_[A-Z_]` is reserved for all identifiers in C/C++.  So using a single _ is actually fine but since the rules are somewhat arcane and using double __ is safe for all purposes, __ is the most common choice for this purpose just to avoid such confusion.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59921/new/

https://reviews.llvm.org/D59921