[libcxx-commits] [PATCH] D59659: Direction for a fix of PR 41130

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 27 14:14:47 PDT 2019

mclow.lists added a comment.

In D59659#1444658 <https://reviews.llvm.org/D59659#1444658>, @ldionne wrote:

> In D59659#1438461 <https://reviews.llvm.org/D59659#1438461>, @EricWF wrote:
> > We should just fix common type in C++03.
> Did you commit your fix to common_type? I think this would indeed solve this whole issue, right? If so, we should only commit the tests added by this patch.
> Does this make sense @mclow.lists ?

No, I don't think it does.  
I've been waiting for @EricWF 's `common_type` fixes to land.
Once that happens, the problem in the original bug report will still remain.

This patch will need to be reworked - and will become *much* simpler.



More information about the libcxx-commits mailing list