[libcxx-commits] [PATCH] D59727: [libc++] Fix return value of snprintf_l() on Windows when buffer is too small

[Tom Anderson via Phabricator via libcxx-commits]

thomasanderson added a comment.

In D59727#1444732 <https://reviews.llvm.org/D59727#1444732>, @zoecarver wrote:

> @thomasanderson  `vsnprintf` uses `__stdio_common_vsprintf ` on MSVC. Is there a performance hit when only `vsnprintf ` is used?


`vsnprintf` doesn't have a performance hit, but it doesn't allow setting the locale.  The `__libcpp_locale_guard` is the thing that's slow that we're trying to avoid.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59727/new/

https://reviews.llvm.org/D59727