[libcxx-commits] [PATCH] D59886: Heterogeneous lookup for unordered containers (P0919R3)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 3 inline comments as done.
zoecarver added inline comments.


================
Comment at: include/__hash_table:36
+template<class _Hash, class _Pred, class = void>
+struct __key_equal {
+    using type = _Pred;
----------------
Not quite sure if this is the correct place for this to go, but didn't want to duplicate code.


================
Comment at: include/unordered_map:428
 
+#define __cpp_lib_generic_unordered_lookup
+
----------------
Also not sure if this is where this should go.


================
Comment at: test/std/containers/key_equal.fail.cpp:27
+{
+    // expected-error {{type 'const custom_hash' does not provide a call operator}}
+    // expected-error {{static_assert failed due to requirement '__check_hash_requirements<int, custom_hash>::value' "the specified hash does not meet the Hash requirements"}}
----------------
These comments describe errors in other files. What line should they go on and how should they be formatted? 


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59886/new/

https://reviews.llvm.org/D59886