[libcxx-commits] [PATCH] D59882: [libc++] Rename span's as_writeable_bytes to as_writable_bytes

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 27 08:12:04 PDT 2019


ldionne added a comment.

This is NOT an ABI break because the methods involved have `INLINE_VISIBILITY`.

This IS an API break because we're renaming a function. However, I suspect that function isn't used all that often, and for those users that will be broken, the fix is trivial (just rename the function). I also know that we haven't been shipping this for a long time, so there isn't like years of code written on top of this bug. This is why I suggest we don't try to retain the old name.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59882/new/

https://reviews.llvm.org/D59882





More information about the libcxx-commits mailing list