[libcxx-commits] [PATCH] D59839: Open fstream files in O_CLOEXEC mode when possible.

Dan Albert via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 26 14:56:07 PDT 2019


danalbert added a comment.

In D59839#1443731 <https://reviews.llvm.org/D59839#1443731>, @mclow.lists wrote:

> How did you decide which modes fell into "when possible"?


AIUI it's all the modes, the "whenever possible" applies to platform support. The configuration I've checked in is definitely non-exhaustive, but I also don't know how to come up with an exhaustive list. I was able to check Android and glibc easily enough since that's what in front of me, but I figure anyone else that wants this behavior can easily update `__config`.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59839/new/

https://reviews.llvm.org/D59839





More information about the libcxx-commits mailing list