[libcxx-commits] [PATCH] D59572: Fix and speedup __libcpp_locale_guard on Windows

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 26 14:53:15 PDT 2019


mclow.lists added inline comments.


================
Comment at: include/__locale:96
+      const char* __new_locale = setlocale(LC_ALL, __locale);
+      if (__new_locale == nullptr)
+        __throw_bad_alloc();
----------------
I really doubt that this is going to work for anyone who builds with exceptions disabled.

On the other hand, maybe that's "not a thing" on windows and/or mingw.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59572/new/

https://reviews.llvm.org/D59572





More information about the libcxx-commits mailing list