[libcxx-commits] [libcxx] r357010 - [coroutines] Add std::experimental::task<T> type

Brian Gesiak via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 26 11:10:22 PDT 2019

Oh, I'm very sorry! Lewis asked how to commit it, and since he didn't
have commit access I offered to do so on his behalf. I misinterpreted
the check marks on Phabricator https://reviews.llvm.org/D46140 and I
thought it had been accepted -- I didn't realize it hadn't been.

Please let me know if you'd like for me to revert this change. And sorry again!

- Brian Gesiak

On Tue, Mar 26, 2019 at 2:07 PM Marshall Clow <mclow.lists at gmail.com> wrote:
> On Tue, Mar 26, 2019 at 11:01 AM Brian Gesiak via libcxx-commits <libcxx-commits at lists.llvm.org> wrote:
>> Author: modocache
>> Date: Tue Mar 26 10:46:06 2019
>> New Revision: 357010
>> URL: http://llvm.org/viewvc/llvm-project?rev=357010&view=rev
>> Log:
>> [coroutines] Add std::experimental::task<T> type
>> Summary:
>> Adds the coroutine `std::experimental::task<T>` type described in proposal P1056R0.
>> See https://wg21.link/P1056R0.
> Was this patch reviewed before committing?
> All I saw was https://reviews.llvm.org/D46140, which:
> (a) had been fallow for 6 months until yesterday afternoon,
> (b) not approved by any of the libc++ approvers. (@ldionne, @EricWF, and myself)
> -- Marshall

More information about the libcxx-commits mailing list