[libcxx-commits] [PATCH] D59727: [libc++] Fix return value of snprintf_l() on Windows when buffer is too small

Tom Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 26 12:24:05 PDT 2019


thomasanderson added a comment.

In D59727#1442500 <https://reviews.llvm.org/D59727#1442500>, @EricWF wrote:

> OK, but can you open a bug that we need to find a better solution in the long run?


Done: https://bugs.llvm.org/show_bug.cgi?id=41244
Also added  a FIXME in code

In D59727#1442687 <https://reviews.llvm.org/D59727#1442687>, @mstorsjo wrote:

> FWIW, this will break mingw builds that use the old msvcrt.dll. Since a couple years, mingw-w64 also supports the UCRT, but this is not the default configuration upstream yet (while it is in my own builds).


Latest patch adds "!defined(__MINGW32__)"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59727/new/

https://reviews.llvm.org/D59727





More information about the libcxx-commits mailing list