[libcxx-commits] [PATCH] D59678: Make common_type's implementation common

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 25 10:43:00 PDT 2019


mclow.lists accepted this revision.
mclow.lists added a comment.

In D59678#1439883 <https://reviews.llvm.org/D59678#1439883>, @ldionne wrote:

> This is good by me (but you should address Marshall's comment about the tests). Cool trick with the macro for variadic templates.


I told Eric (privately) that I was fine with him cleaning up the test in a separate commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59678/new/

https://reviews.llvm.org/D59678





More information about the libcxx-commits mailing list