[libcxx-commits] [PATCH] D59678: Make common_type's implementation common

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF marked 2 inline comments as done.
EricWF added inline comments.


================
Comment at: include/type_traits:2189
+    : conditional<
+        is_same<_Tp, typename decay<_Tp>::type>::value && is_same<_Up, typename decay<_Up>::type>::value,
+        __common_type2_imp<_Tp, _Up>,
----------------
ldionne wrote:
> If one is already decayed but the other isn't, shouldn't you decay the one that isn't?
No. The standard is very specific about this:

http://eel.is/c++draft/meta.trans.other#3.3


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59678/new/

https://reviews.llvm.org/D59678