[libcxx-commits] [PATCH] D59512: Add relational benchmark against a string constant.

[Samuel Benzaquen via Phabricator via libcxx-commits]

sbenza marked an inline comment as done.
sbenza added inline comments.


================
Comment at: libcxx/benchmarks/string.bench.cpp:272
+      benchmark::DoNotOptimize(Lhs);
+      switch (Rel()) {
+      case Relation::Eq:
----------------
EricWF wrote:
> We want this switch to be optimized away, right?
`Rel()` returns a constexpr value, so the switch is optimized away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59512/new/

https://reviews.llvm.org/D59512