[libcxx-commits] [PATCH] D59598: Make the `<charconv>` header usable with C++11

[Zhihao Yuan via Phabricator via libcxx-commits]

lichray accepted this revision.
lichray added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/support/charconv_test_helpers.h:125
         char* last;
-        auto r = strtoll(p, &last, base);
+        long long r = strtoll(p, &last, base);
         assert(last == ep);
----------------
Using `auto` here is fine.


================
Comment at: libcxx/test/support/charconv_test_helpers.h:134
         char* last;
-        auto r = strtoull(p, &last, base);
+        unsigned long long r = strtoull(p, &last, base);
         assert(last == ep);
----------------
Ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59598/new/

https://reviews.llvm.org/D59598