[libcxx-commits] [PATCH] D59525: Speed up certain locale functions on Windows
Shoaib Meenai via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 19 13:11:08 PDT 2019
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM, though you'll wanna update the commit message.
Comment at: src/support/win32/locale_win32.cpp:96
+ int result = _vsprintf_s_l( ret, n, format, loc, ap );
Any reason for preferring this over `_vsnprintf_l`? I think they'll end up being basically equivalent here, except `_vsnprintf_l` is more in line with the else branch.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits