[libcxx-commits] [PATCH] D55840: P0722R3: Implement library support for destroying delete

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Please explain to me why we should have this in pre-C++20 dialects.



================
Comment at: include/new:37
 enum class align_val_t : size_t {}; // C++17
+struct destroying_delete_t {
+  explicit destroying_delete_t() = default;
----------------
ldionne wrote:
> Please note that those are C++20 additions.
This comment stands, those declarations should have `// C++20` in the synopsis.


================
Comment at: include/new:167
+struct destroying_delete_t {
+#ifndef _LIBCPP_CXX03_LANG
+  explicit destroying_delete_t() = default;
----------------
See, that's one reason why I don't like back-porting recent features to older dialects.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55840/new/

https://reviews.llvm.org/D55840