[libcxx-commits] [libcxx] r356429 - Remove unused try catch blocks from old debug tests

Eric Fiselier via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 18 17:00:30 PDT 2019


Author: ericwf
Date: Mon Mar 18 17:00:30 2019
New Revision: 356429

URL: http://llvm.org/viewvc/llvm-project?rev=356429&view=rev
Log:
Remove unused try catch blocks from old debug tests

Modified:
    libcxx/trunk/test/support/container_debug_tests.hpp

Modified: libcxx/trunk/test/support/container_debug_tests.hpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/support/container_debug_tests.hpp?rev=356429&r1=356428&r2=356429&view=diff
==============================================================================
--- libcxx/trunk/test/support/container_debug_tests.hpp (original)
+++ libcxx/trunk/test/support/container_debug_tests.hpp Mon Mar 18 17:00:30 2019
@@ -149,39 +149,27 @@ struct BasicContainerChecks {
   }
 
   static void run_iterator_tests() {
-    try {
-      TestNullIterators<iterator>();
-      TestNullIterators<const_iterator>();
-      if constexpr (IsBiDir) { DecrementBegin(); }
-      IncrementEnd();
-      DerefEndIterator();
-    } catch (...) {
-      assert(false && "uncaught debug exception");
-    }
+    TestNullIterators<iterator>();
+    TestNullIterators<const_iterator>();
+    if constexpr (IsBiDir) { DecrementBegin(); }
+    IncrementEnd();
+    DerefEndIterator();
   }
 
   static void run_container_tests() {
-    try {
-      CopyInvalidatesIterators();
-      MoveInvalidatesIterators();
-      if constexpr (CT != CT_ForwardList) {
-        EraseIter();
-        EraseIterIter();
-      }
-    } catch (...) {
-      assert(false && "uncaught debug exception");
+    CopyInvalidatesIterators();
+    MoveInvalidatesIterators();
+    if constexpr (CT != CT_ForwardList) {
+      EraseIter();
+      EraseIterIter();
     }
   }
 
   static void run_allocator_aware_tests() {
-    try {
-      SwapNonEqualAllocators();
-      if constexpr (CT != CT_ForwardList ) {
-        // FIXME: This should work for both forward_list and string
-        SwapInvalidatesIterators();
-      }
-    } catch (...) {
-      assert(false && "uncaught debug exception");
+    SwapNonEqualAllocators();
+    if constexpr (CT != CT_ForwardList ) {
+      // FIXME: This should work for both forward_list and string
+      SwapInvalidatesIterators();
     }
   }
 




More information about the libcxx-commits mailing list