[libcxx-commits] [PATCH] D59489: [libc++][CMake] Clean up some of the libc++ re-exporting logic

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 18 07:33:18 PDT 2019


ldionne created this revision.
ldionne added a reviewer: dexonsmith.
Herald added subscribers: libcxx-commits, arphaman, jkorous, christof, mgorny.
Herald added a reviewer: EricWF.

This change allows specifying the version of libc++abi's ABI to re-export
when configuring CMake. It also clearly identifies which ABI version of
libc++abi each export file contains.

Finally, it removes hardcoded knowledge about the 10.9 SDK for MacOS,
since that knowledge is not relevant anymore. Indeed, libc++ can't be
built with the toolchain that came with the 10.9 SDK anyway because
the version of Clang it includes is too old (for example if you want
to build a working libc++.dylib, you need bugfixes to visibility
attributes that are only in recent Clangs).


Repository:
  rCXX libc++

https://reviews.llvm.org/D59489

Files:
  libcxx/CMakeLists.txt
  libcxx/cmake/Modules/HandleLibCXXABI.cmake
  libcxx/docs/index.rst
  libcxx/lib/CMakeLists.txt
  libcxx/lib/libc++abi.exp
  libcxx/lib/libc++abi.v1.exp
  libcxx/lib/libc++abi.v2.exp
  libcxx/lib/libc++abi2.exp
  libcxx/lib/libc++sjlj-abi.exp
  libcxx/lib/libc++sjlj-abi.v1.exp
  libcxx/www/index.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59489.191087.patch
Type: text/x-patch
Size: 14642 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190318/3249111b/attachment-0001.bin>


More information about the libcxx-commits mailing list