[libcxx-commits] [PATCH] D55889: The initial commit of the Parallel STL upstream

Thu Mar 14 12:36:46 PDT 2019

ldionne added a comment.

In D55889#1429801 <https://reviews.llvm.org/D55889#1429801>, @ldionne wrote:

> In D55889#1429783 <https://reviews.llvm.org/D55889#1429783>, @thakis wrote:
>
> > I gave -DLLVM_ENABLE_PROJECTS=all a try today, and it failed like so:
> >
> >   CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
> >     Could NOT find TBB (missing: TBB_IMPORTED_TARGETS tbb) (Required is at
> >     least version "2018")
> >   Call Stack (most recent call first):
> >     /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
> >     /usr/local/google/home/thakis/src/llvm-project/pstl/cmake/FindTBB.cmake:63 (find_package_handle_standard_args)
> >     /usr/local/google/home/thakis/src/llvm-project/pstl/CMakeLists.txt:37 (find_package)
> >
> >
> > Is that expected?
>
>
> No, it's not. The issue is that we only have a backend based on TBB right now.
>
> What I'm going to do is disable the parallel policies by default until we have a backend that does not depend on more than what C++ already requires. We can then make that backend the default-but-not-very-clever backend, with TBB being available as an opt-in.

Should be fixed in r356194. Folks that want to use parallel policies (and the TBB backend) can use `-DPARALLELSTL_USE_PARALLEL_POLICIES=ON` when configuring.

I uninstalled TBB and tested locally. If it doesn't work for you, please LMK.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55889/new/

https://reviews.llvm.org/D55889