[libcxx-commits] [libcxx] r356167 - [libc++][CMake] Do not define `cxx_shared_EXPORTS` when building the shared library

[Louis Dionne via libcxx-commits]

Author: ldionne
Date: Thu Mar 14 10:15:47 2019
New Revision: 356167

URL: http://llvm.org/viewvc/llvm-project?rev=356167&view=rev
Log:
[libc++][CMake] Do not define `cxx_shared_EXPORTS` when building the shared library

CMake will define -Dcxx_shared_EXPORTS when building the shared library
by default. In theory, this is used to signal to the library that we're
building a shared library and that dllimport/dllexport should be used.
However, we already have our own way of doing that, so I'm removing this
define to avoid meaningless command line arguments in the build.

Modified:
    libcxx/trunk/lib/CMakeLists.txt

Modified: libcxx/trunk/lib/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/lib/CMakeLists.txt?rev=356167&r1=356166&r2=356167&view=diff
==============================================================================
--- libcxx/trunk/lib/CMakeLists.txt (original)
+++ libcxx/trunk/lib/CMakeLists.txt Thu Mar 14 10:15:47 2019
@@ -207,6 +207,7 @@ if (LIBCXX_ENABLE_SHARED)
       OUTPUT_NAME   "c++"
       VERSION       "${LIBCXX_ABI_VERSION}.0"
       SOVERSION     "${LIBCXX_ABI_VERSION}"
+      DEFINE_SYMBOL ""
   )
   cxx_set_common_defines(cxx_shared)