[libcxx-commits] [PATCH] D59250: [libc++] Do not force building with -fPIC (re-applying)

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 14 07:37:32 PDT 2019


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX356153: [libc++] Do not force building with -fPIC (re-applying) (authored by ldionne, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D59250?vs=190246&id=190627#toc

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59250/new/

https://reviews.llvm.org/D59250

Files:
  lib/CMakeLists.txt


Index: lib/CMakeLists.txt
===================================================================
--- lib/CMakeLists.txt
+++ lib/CMakeLists.txt
@@ -105,10 +105,6 @@
 endif()
 
 # Setup flags.
-if (NOT WIN32)
-  add_flags_if_supported(-fPIC)
-endif()
-
 add_link_flags_if_supported(-nodefaultlibs)
 
 if (LIBCXX_TARGETING_MSVC)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59250.190627.patch
Type: text/x-patch
Size: 323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190314/91af1af7/attachment.bin>


More information about the libcxx-commits mailing list