[libcxx-commits] [PATCH] D59194: Uglifiy 'internal' namespace

Thu Mar 14 07:29:52 PDT 2019

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D59194#1426420 <https://reviews.llvm.org/D59194#1426420>, @rodgert wrote:

> @ldionne - When Intel added multiple new algorithm implementations, they did so without qualifying these calls. This led to a situation where some were and some weren't qualified.
>
> I chose to make them uniform during the uglification pass, I have a subsequent patch that I'm working on that adds back the namespace qualifications uniformly.
>  I would like to see this patch accepted as is, because that new patch relies on this as a baseline, and it doesn't really change the status quo where we have many calls that are not qualified in the code.
>
> "I know __parallel_or is a reserved name, but I like being consistent especially when it comes to ADL. WDYT?"
>
> According to @rsmith and @jwakely it's not just about consistency -
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60497
>
> So we need to have it and have it applied uniformly.

SGTM

Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59194/new/

https://reviews.llvm.org/D59194