[libcxx-commits] [PATCH] D58679: Update operator+ for basic_string (P1165R1)

Tue Mar 12 11:11:36 PDT 2019

zoecarver marked an inline comment as done.
zoecarver added a comment.

@mclow.lists Yes, I need to update the tests. I also want to try to figure out why `test_neg_one` is failing. I will look into that today.

================
Comment at: include/string:4168

-#endif  // _LIBCPP_CXX03_LANG
+// XXX: I don't think this should be just for _LIBCPP_CXX03_LANG

----------------
mclow.lists wrote:
> Yes, it should, because in C++03 we don't have move semantics.
Sounds good. I will disable overloads that use `std::move` for C++03.

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58679/new/

https://reviews.llvm.org/D58679