[libcxx-commits] [PATCH] D59248: [libc++] Do not share an object library to create the static/shared libraries
Petr Hosek via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 12 11:07:25 PDT 2019
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM, this looks great, I think we should do the same for libc++abi and libunwind. I've added @smeenai since he has CMake expertise.
================
Comment at: libcxx/lib/CMakeLists.txt:209
PROPERTIES
+ COMPILE_FLAGS "${LIBCXX_COMPILE_FLAGS}"
LINK_FLAGS "${LIBCXX_LINK_FLAGS}"
----------------
CMake documentation says that [`COMPILE_FLAGS` is deprecated](https://cmake.org/cmake/help/v3.4/prop_tgt/COMPILE_FLAGS.html) and that we should be using `COMPILE_OPTIONS` or `target_compile_options`.
================
Comment at: libcxx/lib/CMakeLists.txt:237
PROPERTIES
+ COMPILE_FLAGS "${LIBCXX_COMPILE_FLAGS}"
LINK_FLAGS "${LIBCXX_LINK_FLAGS}"
----------------
ditto
Repository:
rCXX libc++
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59248/new/
https://reviews.llvm.org/D59248
More information about the libcxx-commits
mailing list