[libcxx-commits] [PATCH] D59194: Uglifiy 'internal' namespace

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: include/pstl/internal/algorithm_impl.h:68
+    return __except_handler([&]() {
+        return __parallel_or(std::forward<_ExecutionPolicy>(__exec), __first, __last,
+                             [__pred, __is_vector](_ForwardIterator __i, _ForwardIterator __j) {
----------------
Those calls should stay qualified. If a user had a function called `__parallel_or` and `_ForwardIterator` were a custom type, we could end up calling their function because of ADL.

I know `__parallel_or` is a reserved name, but I like being consistent especially when it comes to ADL. WDYT?


Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59194/new/

https://reviews.llvm.org/D59194