[libcxx-commits] [PATCH] D59166: Remove exception throwing debug mode handler support.
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 8 16:50:04 PST 2019
EricWF created this revision.
EricWF added reviewers: mclow.lists, ldionne, thomasanderson.
Herald added subscribers: libcxx-commits, arphaman, christof.
EricWF edited the summary of this revision.
The reason libc++ implemented a throwing debug mode handler was for ease of testing. Specifically,
I thought that if a debug violation aborted, we could only test one violation per file. This made
it impossible to test debug mode. Which throwing behavior we could test more!
However, the throwing approach didn't work either, since there are debug violations underneath noexcept
functions. This lead to the introduction of `_NOEXCEPT_DEBUG`, which was only noexcept when debug
mode was off.
Having thought more and having grown wiser, `_NOEXCEPT_DEBUG` was a horrible decision. It was
viral, it didn't cover all the cases it needed to, and it was observable to the user -- at worst
changing the behavior of their program.
This patch removes the throwing debug handler, and rewrites the debug tests using 'fork-ing' style
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 98084 bytes
Desc: not available
More information about the libcxx-commits