[libcxx-commits] [PATCH] D59224: [libc++] Mark <filesystem> as unavailable on Apple platforms using pragmas

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 11 11:09:49 PDT 2019


ldionne created this revision.
ldionne added reviewers: mclow.lists, EricWF.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, christof.
Herald added a reviewer: serge-sans-paille.

Also add the corresponding XFAILs to tests that require filesystem.
The approach taken to mark <filesystem> as unavailable in this patch
is to mark all the header as unavailable using #pragma clang attribute.
Marking each declaration using the attribute is more intrusive and
does not provide a lot of value right now because pretty much everything
in <filesystem> requires dylib support, often transitively.

This is an alternative to https://reviews.llvm.org/D59093.


Repository:
  rCXX libc++

https://reviews.llvm.org/D59224

Files:
  libcxx/include/__config
  libcxx/include/chrono
  libcxx/include/filesystem
  libcxx/include/fstream
  libcxx/test/libcxx/input.output/filesystems/lit.local.cfg
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/filesystems/lit.local.cfg
  libcxx/test/std/utilities/time/time.clock/time.clock.file/consistency.pass.cpp
  libcxx/test/std/utilities/time/time.clock/time.clock.file/file_time.pass.cpp
  libcxx/test/std/utilities/time/time.clock/time.clock.file/now.pass.cpp
  libcxx/test/std/utilities/time/time.clock/time.clock.file/rep_signed.pass.cpp
  libcxx/utils/libcxx/test/config.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59224.190127.patch
Type: text/x-patch
Size: 14794 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190311/e3e5eeeb/attachment-0001.bin>


More information about the libcxx-commits mailing list