[libcxx-commits] [PATCH] D59152: [libc++] Build <filesystem> support as part of the dylib

Fri Mar 8 13:51:01 PST 2019

ldionne marked an inline comment as done.
ldionne added inline comments.

================
Comment at: libcxx/CMakeLists.txt:79
-  set(ENABLE_FILESYSTEM_DEFAULT OFF)
-endif()
-option(LIBCXX_ENABLE_FILESYSTEM "Build filesystem as part of libc++fs.a"
----------------
jfb wrote:
> Is it OK to turn fielssytem on for WIN32?
Good point. If not, I assume it's just a temporary situation until support is implemented. If that's correct, then I would disable `<filesystem>` for WIN32 using some other means and have a TODO or something like that. If there's a deeper reason, then we may want to consider keeping the ability to have filesystem turned off (but I doubt that).

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59152/new/

https://reviews.llvm.org/D59152