[libcxx-commits] [PATCH] D59146: [libc++] Do not force building with -fPIC

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, christof, mgorny.

Whether we build with -fPIC should be specified by the
CMAKE_POSITION_INDEPENDENT_CODE option at configure time.
Note that this patch doesn't change the behavior when building
by default, since -fPIC is used for shared libraries by default.


Repository:
  rCXX libc++

https://reviews.llvm.org/D59146

Files:
  libcxx/lib/CMakeLists.txt


Index: libcxx/lib/CMakeLists.txt
===================================================================
--- libcxx/lib/CMakeLists.txt
+++ libcxx/lib/CMakeLists.txt
@@ -105,10 +105,6 @@
 endif()
 
 # Setup flags.
-if (NOT WIN32)
-  add_flags_if_supported(-fPIC)
-endif()
-
 add_link_flags_if_supported(-nodefaultlibs)
 
 if (LIBCXX_TARGETING_MSVC)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59146.189897.patch
Type: text/x-patch
Size: 344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190308/94497e8e/attachment.bin>