[libcxx-commits] [PATCH] D59093: [libc++] Mark <filesystem> as unavailable on Apple platforms

Thu Mar 7 10:38:29 PST 2019

ldionne marked an inline comment as done.
ldionne added a comment.

In D59093#1421820 <https://reviews.llvm.org/D59093#1421820>, @mclow.lists wrote:

> I don't like how intrusive and pervasive this is.

Me neither. Per our offline conversation, I'm currently trying to get the `#pragma` approach to work (again). I'll report here.

================
Comment at: libcxx/include/chrono:2830
 _LIBCPP_BEGIN_NAMESPACE_FILESYSTEM
-struct _FilesystemClock {
+struct _LIBCPP_AVAILABILITY_FILESYSTEM _FilesystemClock {
 #if !defined(_LIBCPP_HAS_NO_INT128)
----------------
mclow.lists wrote:
> This is a ABI change for people who are using the filesystem.
> A public symbol has become non-public.
Sorry, I don't follow you here. How did I change the symbol?

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59093/new/

https://reviews.llvm.org/D59093