[libcxx-commits] [PATCH] D59093: [libc++] Mark <filesystem> as unavailable on Apple platforms

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 7 07:04:18 PST 2019


ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, christof.
Herald added a reviewer: serge-sans-paille.

Also add the corresponding XFAILs to tests that require filesystem.
Note that I did try to use a less intrusive approach using pragma
clang attribute, but this didn't work due to apparent bugs in Clang
(which should be fixed independently but should not delay this change).

Also note that we mark the functions as being introduced in versions
99.99 of the platforms because of a Clang bug (PR40991), which causes
a hard error when an unavailable function is used to initialize the
default argument of another unavailable function. We run into this
issue with functions like proximate().


Repository:
  rCXX libc++

https://reviews.llvm.org/D59093

Files:
  libcxx/include/__config
  libcxx/include/chrono
  libcxx/include/filesystem
  libcxx/include/fstream
  libcxx/test/libcxx/input.output/filesystems/lit.local.cfg
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/filesystems/lit.local.cfg
  libcxx/test/std/utilities/time/time.clock/time.clock.file/consistency.pass.cpp
  libcxx/test/std/utilities/time/time.clock/time.clock.file/file_time.pass.cpp
  libcxx/test/std/utilities/time/time.clock/time.clock.file/now.pass.cpp
  libcxx/test/std/utilities/time/time.clock/time.clock.file/rep_signed.pass.cpp
  libcxx/utils/libcxx/test/config.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59093.189712.patch
Type: text/x-patch
Size: 49547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190307/7d7a2994/attachment-0001.bin>


More information about the libcxx-commits mailing list