[libcxx-commits] [PATCH] D58987: Make underlying_type SFINAE-friendly

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: test/std/utilities/meta/meta.trans/meta.trans.other/underlying_type.pass.cpp:37
+template <class T>
+constexpr bool test_sfinae_v() // This is a function so it is valid pre-c++14
+{
----------------
EricWF wrote:
> This test runs in C++03 mode. Which is weird because it can use a lot of C++11 features; but `constexpr` isn't one of them.
> 
> In C++11 this is a great improvement over my messy test. But the mess is needed for C++03.
I thought about that but IIRC `underlying_type` wasn't added until 2011. I can update if needed though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58987/new/

https://reviews.llvm.org/D58987