[libcxx-commits] [PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone marked an inline comment as done.
Quuxplusone added inline comments.


================
Comment at: src/experimental/memory_resource.cpp:29
-public:
-    ~__new_delete_memory_resource_imp() = default;
-
----------------
EricWF wrote:
> Why are you removing this?
Just removing unnecessary cruft. Same reason I added `override` (and removed `virtual`) on the other methods, and removed `protected:`, and removed the `__` sigilling on function parameters in this .cpp file.

I had done a lot more random cleanup originally, and then you said "unrelated, please revert" so I did, but I assume I just kept all the cleanups in this one class since I was touching this range of lines no matter what.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47344/new/

https://reviews.llvm.org/D47344