[libcxx-commits] [PATCH] D59029: [libc++] Do not specify the underlying type of memory_order

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 6 09:35:54 PST 2019


ldionne added a comment.

In D59029#1420019 <https://reviews.llvm.org/D59029#1420019>, @ldionne wrote:

> [...]
>
> TBH, I don't think there's a lot of value in this. However, if we care that much about this, then I'd probably revert my previous position of not back-porting the enum class behavior to pre-C++20. IOW, instead of adding this complexity, I'd just make the definition the same in C++17 and C++20, and we'd be non-conforming in C++17.


Or we could do that in a test only, as Marshall suggested.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59029/new/

https://reviews.llvm.org/D59029





More information about the libcxx-commits mailing list